[ Sorry for very late response ] > On 27-Aug-2021, at 6:28 PM, Martin Liška <mli...@suse.cz> wrote: > > On 8/27/21 14:44, Ankur Saini wrote: >> While working on patch to convert most of the 8 whitespace characters to >> tabs in the analyzer’s source, I see this weird behaviour where at some >> places indentation looks weird when viewed in patch file ( generated via >> “git format-patch” ) but looks alright when viewed in text editor. > > Yes, I can confirm the patch fixed the white spaces, you can verify that with: > $ git diff | ./contrib/check_GNU_style.py - > ... > > Note there are some other formatting issues reported by the script.
Yes, I see that too, and have fixed most of them Unfortunately, I can’t seem to find a way to avoid the following report. --- === ERROR type #1: lines should not exceed 80 characters (1 error(s)) === gcc/analyzer/diagnostic-manager.cc:2152:80: = cg_superedge.map_expr_from_caller_to_callee (caller_var, — Also, does these kinds of patches require some special changelog or should I proceed in usual fashion ? == Here is updated patch : == Thanks - Ankur
