Hi,
On Fri, Aug 20 2021, Martin Jambor wrote:
> To verify other changes in the patch series, I have been searching for
> "Invalid sum of caller counts" string in symtab dump but found that
> there are false warnings about functions which have their body removed
> because they are now unreachable. Those are of course invalid and so
> this patches avoids checking such cgraph_nodes.
>
> gcc/ChangeLog:
>
> 2021-08-20 Martin Jambor <mjam...@suse.cz>
>
> * cgraph.c (cgraph_node::dump): Do not check caller count sums if
> the body has been removed. Remove trailing whitespace.
I have pushed this patch as obvious but like to ping the rest of the
series.
Thanks,
Martin
> ---
> gcc/cgraph.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/cgraph.c b/gcc/cgraph.c
> index 8f3af003f2a..de078653781 100644
> --- a/gcc/cgraph.c
> +++ b/gcc/cgraph.c
> @@ -2236,7 +2236,7 @@ cgraph_node::dump (FILE *f)
> }
> fprintf (f, "\n");
>
> - if (count.ipa ().initialized_p ())
> + if (!body_removed && count.ipa ().initialized_p ())
> {
> bool ok = true;
> bool min = false;
> @@ -2245,7 +2245,7 @@ cgraph_node::dump (FILE *f)
> FOR_EACH_ALIAS (this, ref)
> if (dyn_cast <cgraph_node *> (ref->referring)->count.initialized_p ())
> sum += dyn_cast <cgraph_node *> (ref->referring)->count.ipa ();
> -
> +
> if (inlined_to
> || (symtab->state < EXPANSION
> && ultimate_alias_target () == this && only_called_directly_p ()))
> --
> 2.32.0
