> I find the other_cond support a bit confusing. Is this for -mcmodel > perhaps? Why not just say that if so?
I suppose we might have other multilib options other than -march, -mabi and -mcmodel, so I keep the flexibility here. > riscv_multi_lib_info_t::parse > Calls riscv_subset_list::parse twice when path == ".", the call inside > the if looks unnecessary. Thanks, good catch ! > It isn't clear how the loop with the comment "ignore march and mabi option > in cond string" can work. It looks like it computes other_cond, but > assumes that there is at most one other_cond, and that it is always at the > end of the list since otherwise the length won't be computed correctly. > But it doesn't check these constraints. Do you have examples showing how > this works? > And maybe a little better commentary explaining what this loop does to > make it easier to understand. It doesn't mention that it computes > other_cond for instance. Seriously, I also spend some time remembering what they are doing...so I rewrite that to make that easier to understand instead of copying gcc.c if possible.
