On Thu, 2021-09-09 at 07:45 +0000, Petter Tomner wrote: > Hi, > > I tested it on another machine over ssh and newer gdb:s (8.3+) clobbers > the output with color escapes so I had to disable colors > for the gdb session in jit.exp for the regex matching to work properly: > > + verbose "Disable color styling in GDB newer then 8.3 (errors on > older)" > + send "set style enabled off\n" > > On pre 8.3 gdb:s that will be an ignored syntax error. > > With that change it passes the check-jit test on that machine too. > > === jit Summary === > > # of expected passes 12073 > > I squashed the patches and attached it to this mail (with the above > change).
Great, thanks. > > > No, I don't have push rights to the GCC repo. Should I request it? In theory I can push the patch on your behalf, but I'm hoping that you'll want to contribute other patches to libgccjit/GCC, so I'd prefer it if you got push rights and did it yourself. I'm happy to sponsor you for access; see: https://gcc.gnu.org/gitwrite.html#authenticated Thanks again for the patch Dave > > Regards, > Petter > > > -----Ursprungligt meddelande----- > Från: David Malcolm <dmalc...@redhat.com> > Skickat: den 8 september 2021 14:49 > Till: Petter Tomner <tom...@kth.se>; gcc-patches@gcc.gnu.org; > j...@gcc.gnu.org > Ämne: Re: Sv: [PATCH 1/2 v2] jit : Generate debug info for variables > > On Tue, 2021-09-07 at 16:18 +0000, Petter Tomner via Gcc-patches wrote: > > I realized I still managed to mess up some WS. I have attached a > > patch > > that is the same, except fixes the WS issue underneath. > > > > Regards, Petter > > > > + FOR_EACH_VEC_ELT (m_globals, i, global) > > + rest_of_decl_compilation (global, true, true); > > Thanks for the updated patch. > > Looks good to me, assuming it's been tested successfully. It should be > combined with the testcase into a single commit when pushed. > > Do you have push rights to the GCC git repo? > > Dave > >
