On Thu, Jul 29, 2021 at 08:31:04AM -0500, Bill Schmidt wrote: > It seems quite strange for these to be "vector long" for 64-bit and > "vector long long" for 32-bit, when "vector long long" will do for both.
Yeah. For most builtins the only thing that matters is the mode the types map to. Similarly we want "vector int" instead of "vector long" on both ilp32 and lp64. > + V2DI_type_node = rs6000_vector_type (TARGET_POWERPC64 ? "__vector long" > + : "__vector long long", > + long_long_integer_type_node, 2); The same as before: either ? and : on the same line, or both should start a new line. Or use some temporary name. Or write an "if" around the whole thing (this compiles to the same machine code -- source code should be optimised for the human reader, the compiler does not care at all, you almost never can use that as excuse :-) ) Anyway, you know what is needed :-) Okay for trunk. Thanks! Segher
