On Thu, Aug 26, 2021 at 6:53 PM Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > Hi! > > On Thu, Aug 26, 2021 at 02:57:35PM -0400, David Edelsohn wrote: > > * config/rs6000/ibm-ldouble.c (ldouble_qadd_internal): Rename > > from > > __gcc_qadd. > > (__gcc_qadd): Call ldouble_qadd_internal. > > (__gcc_qsub): Call ldouble_qadd_internal with second long double > > argument negated. > > Still looks good, please commit. Thanks :-) > > > +static inline IBM128_TYPE > > +ldouble_qadd_internal (double a, double aa, double c, double cc) > > Does it end up actually inlined, or as one static function that both > __gcc_qadd and __gcc_qsub use? This is fine for complexity, it is just > a simple tail-call jump, just wondering what the compiler thinks is best > here (it matters in other cases, if the inline function has conditional > branches for example).
I confirmed that the implementation is inlined in both functions when compiled with optimization, and the negation is propagated into qsub. Thanks, David
