On Tue, Aug 17, 2021 at 9:31 PM Thomas Schwinge <tho...@codesourcery.com> wrote: > > Hi! > > On 2021-08-17T09:27:46-0400, David Malcolm via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: > > On Tue, 2021-08-17 at 11:17 +0200, Thomas Schwinge wrote: > >> "Turn > >> global 'ggc_force_collect' variable into 'force_collect' parameter to > >> 'ggc_collect'" > > > Looks good to me, but bool params can be unclear - maybe introduce an > > enum to make the meaning more explicit to the reader of the code? > > I actually had contemplated that, but then went for the simpler 'bool' > variant... ;-) But yes, it's a good suggestion, thanks. OK to push the > attached "Turn 'bool force_collect' parameter to 'ggc_collect' into an > 'enum ggc_collect mode'"?
OK. > > Grüße > Thomas > > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 > München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas > Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht > München, HRB 106955
