Jonathan Wright <jonathan.wri...@arm.com> writes:
> Hi,
>
> I've corrected the quoting and moved everything on to one line.
>
> Ok for master?
>
> Thanks,
> Jonathan
>
> ---
>
> gcc/testsuite/ChangeLog:
>
> 2021-08-04 Jonathan Wright <jonathan.wri...@arm.com>
>
> * gcc.target/aarch64/vector_structure_intrinsics.c: Restrict
> tests to little-endian targets.
OK, thanks.
Richard
> From: Richard Sandiford <richard.sandif...@arm.com>
> Sent: 06 August 2021 13:24
> To: Jonathan Wright <jonathan.wri...@arm.com>
> Cc: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; Christophe Lyon
> <christophe.lyon....@gmail.com>
> Subject: Re: [PATCH] testsuite: aarch64: Fix failing vector structure tests
> on big-endian
>
> Jonathan Wright <jonathan.wri...@arm.com> writes:
>> diff --git a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
>> b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
>> index
>> 60c53bc27f8378c78b119576ed19fde0e5743894..a8e31ab85d6fd2a045c8efaf2cbc42b5f40d2411
>> 100644
>> --- a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
>> +++ b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
>> @@ -197,7 +197,8 @@ TEST_ST1x3 (vst1q, uint64x2x3_t, uint64_t*, u64, x3);
>> TEST_ST1x3 (vst1q, poly64x2x3_t, poly64_t*, p64, x3);
>> TEST_ST1x3 (vst1q, float64x2x3_t, float64_t*, f64, x3);
>>
>> -/* { dg-final { scan-assembler-not "mov\\t" } } */
>> +/* { dg-final { scan-assembler-not {"mov\\t"} {
>> + target { aarch64_little_endian } } ) } */
>
> I think this needs to stay on line. We should also either keep the
> original quoting on the regexp or use {mov\t}. Having both forms
> of quote would turn it into a test for the characters:
>
> "mov\t"
>
> (including quotes and backslash).
>
> Thanks,
> Richard
>
>
>>
>> /* { dg-final { scan-assembler-times "tbl\\t" 18} } */
>> /* { dg-final { scan-assembler-times "tbx\\t" 18} } */
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> index
> 3e7e572bf39659ecf2f17751d92a4a99a4f2bf8b..89e9de18a92dbc00e58261e4558b3cff38c7ca75
> 100644
> --- a/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> +++ b/gcc/testsuite/gcc.target/aarch64/vector_structure_intrinsics.c
> @@ -263,7 +263,7 @@ TEST_ST1x3 (vst1q, uint64x2x3_t, uint64_t*, u64, x3);
> TEST_ST1x3 (vst1q, poly64x2x3_t, poly64_t*, p64, x3);
> TEST_ST1x3 (vst1q, float64x2x3_t, float64_t*, f64, x3);
>
> -/* { dg-final { scan-assembler-not "mov\\t" } } */
> +/* { dg-final { scan-assembler-not "mov\\t" { target aarch64_little_endian }
> } } */
>
> /* { dg-final { scan-assembler-times "tbl\\t" 18} } */
> /* { dg-final { scan-assembler-times "tbx\\t" 18} } */
