Looks good to me,  but I have no right to approve.


On Wed, Jun 30, 2021 at 9:17 PM Xi Ruoyao <xry...@mengyan1223.wang> wrote:
>
> Ping patch:
> https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573213.html
>
> Status update: bootstrapped with BOOT_CFLAGS="-O3 -mmsa -mloongson-mmi"
> (it failed without the patch), and regtested on mips64el-linux-gnu with
> no new regression.
>
> On Sat, 2021-06-19 at 15:34 +0800, Xi Ruoyao wrote:
> > Check if the vector mode is really supported by MSA in certain cases,
> > instead of testing ISA_HAS_MSA.  Simply testing ISA_HAS_MSA can cause
> > ICE when MSA is enabled besides other MIPS SIMD extensions (notably,
> > Loongson MMI).
> >
> > Bootstrapped and tested on mips64el-linux-gnu.  OK to commit?
> >
> > gcc/
> >
> >         * config/mips/mips.c (mips_const_insns): Use
> > MSA_SUPPORTED_MODE_P
> >         instead of ISA_HAS_MSA.
> >         (mips_expand_vec_unpack): Likewise.
> >         (mips_expand_vector_init): Likewise.
> >
> > gcc/testsuite/
> >
> >         * testsuite/gcc.target/mips/pr100760.c: New test.
> >         * testsuite/gcc.target/mips/pr100761.c: New test.
> >         * testsuite/gcc.target/mips/pr100762.c: New test.
> --
> Xi Ruoyao <xry...@mengyan1223.wang>
>

Reply via email to