On 6/22/2021 1:05 AM, Xi Ruoyao via Gcc-patches wrote:
mips.exp does not support -fno-inline, causing the tests return "ERROR:
Unrecognised option: -fno-inline for dg-options ... ".
Use noinline attribute like other mips target tests, to workaround it.
gcc/testsuite/
* gcc.target/mips/cfgcleanup-jalr2.c: Remove -fno-inline and add
__attribute__((noinline)).
* gcc.target/mips/cfgcleanup-jalr3.c: Likewise.
I'd like to know a bit more here. mips.exp shouldn't care about the
options passed to the compiler and to the best of my knowledge
-fno-inline is still a valid GCC option. So while I don't think the
patch itself is wrong, I question if it's necessary and whether or not
your just papering over some other issue.
Jeff
