Hi Gerald: Thanks your patch, my grammar is really...weak :p
Hi Bernhard: >> + <li>Add new option <code>-misa-spec=*</code> to control ISA spec version. >> + This controls the default version of each extensions. >> + It defaults to 2.2.</li> > Is "each extensions" in plural really correct gramatically? > "default version of extensions" or > "default version of each extension" > And is "version of" correct WRT the code or does the code control the > version "for extensions"? > > I.e. > "to control the default ISA spec version for extensions" if that's what > the option does? ISA spec version control a set of default version, like that: 2.2 = { i-ext=2.0, m-ext=2.0, a-ext=2.0 f-ext=2.0 ..} 20190608 = { i-ext=2.1, m-ext=2.0, a-ext=2.0 f-ext=2.2 ...} 20191213 = { i-ext=2.1, m-ext=2.0, a-ext=2.1 f-ext=2.2 ...} so...I think "to control the default ISA spec version for extensions" should be right, feel free to commit patches to fix the gramm issue, I will be very grateful :) On Mon, Jun 14, 2021 at 3:41 PM Gerald Pfeifer <ger...@pfeifer.com> wrote: > > On Sun, 13 Jun 2021, Bernhard Reutner-Fischer wrote: > >> + <li>Add new option <code>-misa-spec=*</code> to control ISA spec > >> version. > >> + This controls the default version of each extensions. > >> + It defaults to 2.2.</li> > > Is "each extensions" in plural really correct gramatically? > > "default version of extensions" or > > "default version of each extension" > > No, that one escaped my edits - good catch, Bernhard! > > > And is "version of" correct WRT the code or does the code control the > > version "for extensions"? > > > > I.e. > > "to control the default ISA spec version for extensions" if that's what > > the option does? > > Let's see what Kito advises. Once we know, feel free to make a change or > advise and I'll do. > > Thanks, > Gerald