On 10.06.21 16:24, Martin Liška wrote:
I'm sending a small update that handles some flake8 issues and as defined in setup.cfg, line limit for the file is 120 characters.
Aha, the known issue that Ubuntu 20.04 has a too old flake8 such that I only see a subset of the errors ...
I have one question: Do we really need the revert regex? What about using GitCommit::revert_commit?
I think it would be fine – glancing at recent commits, I think only the following would be rejected: * https://gcc.gnu.org/g:0886426f5f543e813c1a61e18da6616caf377dfc And one can argue about whether it should or shouldn't be rejected. The other commits I found either have the 'This reverts commit' line – and/or have the PR both in the subject and in the changelog part. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
