Hi Tom!
First, thanks for looking into this PR99555!
I can't comment on the OpenMP/nvptx changes, so just the following:
On 2021-04-23T18:48:01+0200, Tom de Vries <tdevr...@suse.de> wrote:
> --- a/libgomp/testsuite/libgomp.fortran/task-detach-6.f90
> +++ b/libgomp/testsuite/libgomp.fortran/task-detach-6.f90
> @@ -1,6 +1,5 @@
> ! { dg-do run }
>
> -! { dg-additional-sources on_device_arch.c }
> ! { dg-prune-output "command-line option '-fintrinsic-modules-path=.*' is
> valid for Fortran but not for C" }
Please remove the 'dg-prune-output', too. ;-)
Your changes leave
'libgomp/testsuite/lib/libgomp.exp:check_effective_target_offload_device_nvptx',
'libgomp/testsuite/libgomp.c-c++-common/on_device_arch.h',
'libgomp/testsuite/libgomp.fortran/on_device_arch.c' unused. Should we
keep those for a potential future use (given that they've been tested to
work) or remove (as now unused, danger of bit-rot)?
Grüße
Thomas
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank
Thürauf
