[committed] libstdc++: Fix std::jthread assertion and re-enable skipped test

[Jonathan Wakely via Gcc-patches]

libstdc++-v3/ChangeLog:

        * include/std/thread (jthread::_S_create): Fix static assert
        message.
        * testsuite/30_threads/jthread/95989.cc: Re-enable test.
        * testsuite/30_threads/jthread/jthread.cc: Do not require
        pthread effective target.
        * testsuite/30_threads/jthread/2.cc: Moved to...
        * testsuite/30_threads/jthread/version.cc: ...here.

Tested powerpc64le-linux. Committed to trunk.

Let's see if this test is actually fixed, or if it still causes
failures on some targets.



commit 60a156ae53e976dfe44689f7c89e607596e7cf67
Author: Jonathan Wakely <jwak...@redhat.com>
Date:   Mon May 17 14:55:22 2021

    libstdc++: Fix std::jthread assertion and re-enable skipped test
    
    libstdc++-v3/ChangeLog:
    
            * include/std/thread (jthread::_S_create): Fix static assert
            message.
            * testsuite/30_threads/jthread/95989.cc: Re-enable test.
            * testsuite/30_threads/jthread/jthread.cc: Do not require
            pthread effective target.
            * testsuite/30_threads/jthread/2.cc: Moved to...
            * testsuite/30_threads/jthread/version.cc: ...here.

diff --git a/libstdc++-v3/include/std/thread b/libstdc++-v3/include/std/thread
index 886994c1320..f51392ab42c 100644
--- a/libstdc++-v3/include/std/thread
+++ b/libstdc++-v3/include/std/thread
@@ -219,7 +219,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
          {
            static_assert(is_invocable_v<decay_t<_Callable>,
                                         decay_t<_Args>...>,
-                         "std::thread arguments must be invocable after"
+                         "std::jthread arguments must be invocable after"
                          " conversion to rvalues");
            return thread{std::forward<_Callable>(__f),
                          std::forward<_Args>(__args)...};
diff --git a/libstdc++-v3/testsuite/30_threads/jthread/95989.cc 
b/libstdc++-v3/testsuite/30_threads/jthread/95989.cc
index 53f90827f2e..fb3f43bc722 100644
--- a/libstdc++-v3/testsuite/30_threads/jthread/95989.cc
+++ b/libstdc++-v3/testsuite/30_threads/jthread/95989.cc
@@ -20,7 +20,6 @@
 // { dg-require-gthreads {} }
 // { dg-additional-options "-pthread" { target pthread } }
 // { dg-additional-options "-static" { target static } }
-// { dg-skip-if "broken" { *-*-* } }
 
 #include <thread>
 
diff --git a/libstdc++-v3/testsuite/30_threads/jthread/jthread.cc 
b/libstdc++-v3/testsuite/30_threads/jthread/jthread.cc
index 6adc4981175..799787088ac 100644
--- a/libstdc++-v3/testsuite/30_threads/jthread/jthread.cc
+++ b/libstdc++-v3/testsuite/30_threads/jthread/jthread.cc
@@ -16,9 +16,9 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-options "-std=gnu++2a -pthread" }
-// { dg-add-options libatomic }
 // { dg-do run { target c++2a } }
-// { dg-require-effective-target pthread }
+// { dg-add-options libatomic }
+// { dg-additional-options "-pthread" { target pthread } }
 // { dg-require-gthreads "" }
 
 #include <thread>