On Thu, Apr 29, 2021 at 10:02 PM Palmer Dabbelt <palmerdabb...@google.com> wrote:
> This was reported as Bug 94136, which is a year old but was categorized > as a documentation bug. I believe that categorization was incorrect: > having an empty __clear_cache library routine is simply incorrect It affects almost all targets, and fixing RISC-V does nothing useful to change that. x86_64-linux for instance also has an empty __clear_cache function in libgcc.a. We can either fix almost all targets, or we can fix the docs to match reality. Fixing the docs is easier. This is why it is classified as a doc bug. Fixing riscv is nice. You can remove the riscv target setting. But you can't close it because it is still broken for a lot of other targets. Unless maybe this trick of defining CLEAR_INSN_CACHE works for other targets too, in which case maybe we could add a default definition someplace for targets that don't have their own definition that does what your RISC-V patch does. +/* We always have a "clear_cache" insn, which means __builtin__clear_cache > will > + never emit a call to __clear_cache. */ > +#undef CLEAR_INSN_CACHE > +#define CLEAR_INSN_CACHE(BEG, END) __builtin__clear_cache((BEG), (END)); > It is __builtin___clear_cache with 3 underscores before the clear. With this change it works for me. Jim
