On Sat, Feb 4, 2012 at 3:48 AM, Bin Cheng <bin.ch...@arm.com> wrote:
> Hi,
>
> Here is the patch fixing pr51867 by removing the redundant check on
> DECL_ASSEMBLER_NAME_SET_P.
> I also changed '-O0' to '-O1' in signbit-2.c and added a new test.
> The new test case won't bite if target cpu does not support hardware sqrtf
> instruction.
>
> Tested on arm-eabi and x86, Is it OK?

Ok with the comment change

@@ -5745,10 +5745,12 @@
     return targetm.expand_builtin (exp, target, subtarget, mode, ignore);

   /* When not optimizing, generate calls to library functions for a certain
-     set of builtins.  */
+     set of builtins.
+
+     See PR51867.
+     Don't check "DECL_ASSEMBLER_NAME_SET_P (fndecl)" here any more.  */

omitted.

Thanks,
Richard.

> Thanks.
>
> gcc/ChangeLog:
> 2012-02-04  Bin Cheng  <bin.ch...@arm.com>
>
>        PR target/51867
>        * builtins.c (expand_builtin): Don't check
> DECL_ASSEMBLER_NAME_SET_P.
>
> gcc/testsuite/ChangeLog:
> 2012-02-04  Bin Cheng  <bin.ch...@arm.com>
>
>        PR target/51867
>        * testsuite/c-c++-common/dfp/signbit-2.c: Change '-O0' to '-O1'.
>        * testsuite/gcc.dg/pr51867.c: New test.
>

Reply via email to