On 4/21/21 3:03 PM, Richard Biener wrote: > On Wed, Apr 21, 2021 at 2:09 PM Uros Bizjak via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: >> >> On Wed, Apr 21, 2021 at 10:28 AM Martin Liska <mli...@suse.cz> wrote: >>> >>> >>> gcc/ChangeLog: >>> >>> * config/i386/i386.h (PTA_*): Remove. >>> (enum pta_flag): New. >>> (DEF_PTA): Generate PTA_* values from i386.def. >>> * wide-int-bitmask.h (WIDE_INT_BITMASK_FROM_NTH): New macro. >>> * config/i386/i386.def: New file. >> >> Shouldn't this file be rather named i386-isa.def? >> >> Otherwise LGTM, but someone have to approve wide-int-bitmask.h change. > > Hmm, such macro isn't "nice" and as it seems you could have inlined it > at the single use in the source file?
I would use a static method, but that doesn't work with constexpr (at least not in -std=c++11). Let's move the macro to the usage place. Thanks, Martin > >> Uros. >> >>> --- >>> gcc/config/i386/i386.def | 110 +++++++++++++++++++++++++++++++++++++++ >>> gcc/config/i386/i386.h | 106 ++++++------------------------------- >>> gcc/wide-int-bitmask.h | 3 ++ >>> 3 files changed, 128 insertions(+), 91 deletions(-) >>> create mode 100644 gcc/config/i386/i386.def >>>
