On 4/20/2021 6:12 PM, Stafford Horne wrote:
On Tue, Apr 20, 2021 at 05:20:39PM -0600, Jeff Law wrote:
On 4/18/2021 6:10 PM, Stafford Horne via Gcc-patches wrote:
When building libgeos we get an error with:

      linux-uclibc/9.3.0/crtbeginS.o: in function `__do_global_dtors_aux':
      crtstuff.c:(.text+0x118): relocation truncated to fit: R_OR1K_GOT16 
against symbol `__cxa_finalize' defined in .text section in
      
/home/shorne/work/openrisc/3eb9f9d0f6d8274b2d19753c006bd83f7d536e3c/output/host/or1k-buildroot-linux-uclibc/sysroot/lib/libc.so.

This is caused by GOT code having a limit of 64k.  In OpenRISC this
looks to be the only relocation code pattern to be limited to 64k.

This patch allows specifying a new option -mcmodel=large which can be
used to generate 2 more instructions to construct 32-bit addresses for
up to 4G GOTs.

gcc/ChangeLog:

        PR 99783
        * config/or1k/or1k-opts.h: New file.
        * config/or1k/or1k.c (or1k_legitimize_address_1, print_reloc):
        Support generating gotha relocations if -mcmodel=large is
        specified.
        * config/or1k/or1k.h (TARGET_CMODEL_SMALL, TARGET_CMODEL_LARGE):
        New macros.
        * config/or1k/or1k.opt (mcmodel=): New option.
        * doc/invoke.text (OpenRISC Options): Document mcmodel.
Note you're the port maintainer, so you don't need approval to commit this
to GCC.
Thanks for confirming, I know that after Segher told me with some previous
patches. :)

For this series Giulio picked it up and tested it.  We found some issues and I
am going to fix with a V2.  I should commit that version, after the binutils
changes are in.

Sounds good.  Thanks.  Given we're making gcc-11 RCs you'll have to decide if its worth the risk of introducing those changes this late in the cycle is safe or not.

jeff

Reply via email to