Hi,
On Fri, 9 Apr 2021 at 18:44, Hafiz Abid Qadeer <abid_qad...@mentor.com> wrote: > > Thanks for the review. Please see my comments below. > > On 09/04/2021 13:48, Tobias Burnus wrote: > > Hi Abid, > > > > I think that's the same issue as https://gcc.gnu.org/PR98088 > > if so, please add 'PR middle-end/98088' to the changelog. > Done > > > > I think the second testcase is covered, but you could also add > > the first testcase to c-c++-common/goacc/collapse-2.c – the first > > testcase in the PR is for a zero-trip loop. > I have added the tests from the PR. > > >> * testsuite/c-c++-common/goacc/collapse-2.c: New. > > > > The changelog file is in 'gcc/testsuite/', hence, you need a separate entry > > (and > > remove 'testsuite/'). > Done > > >> +/* { dg-skip-if "not yet" { c++ } } */ > > > > Why is the dg-skip-if needed? Codewise it does not seem to be required > > and it also does compile with g++ after applying the patch. > It was in the collapse-1.c file. I have removed it now. > > > > > With this removed and the other nits fixed: LGTM & thanks for the patch. > > Updated patch attached. I will apply if there are no further comments and > once I > get write access. > The new test generates an ICE on aarch64-linux-gnu in the gcc-10 branch: /gcc/testsuite/c-c++-common/goacc/collapse-2.c: In function 'f5._omp_fn.0': /gcc/testsuite/c-c++-common/goacc/collapse-2.c:56:1: error: type mismatch in binary expression signed long long int int D.3972 = .tile.57 * .tile.59; during IPA pass: *free_lang_data /gcc/testsuite/c-c++-common/goacc/collapse-2.c:56:1: internal compiler error: verify_gimple failed 0xdc554e verify_gimple_in_cfg(function*, bool) /gcc/tree-cfg.c:5502 0xc7e7f2 execute_function_todo /gcc/passes.c:1985 0xc7f0bd do_per_function /gcc/passes.c:1647 0xc7f195 execute_todo /gcc/passes.c:2039 Please submit a full bug report, with preprocessed source if appropriate. Please include the complete backtrace with any bug report. See <https://gcc.gnu.org/bugs/> for instructions. compiler exited with status 1 FAIL: c-c++-common/goacc/collapse-2.c (internal compiler error) FAIL: c-c++-common/goacc/collapse-2.c 3 blank line(s) in output FAIL: c-c++-common/goacc/collapse-2.c (test for excess errors) Can you check? Thanks Christophe > Thanks, > Abid
