On Tue, Apr 13, 2021 at 12:18 PM Hongtao Liu <crazy...@gmail.com> wrote:
>
> Hi:
> As described in PR, we introduced tigerlake string in driver-i386.c
> by r9-8652 w/o support -march/tune=tigerlake which causes an error
> when using -march/tune=native with GCC9 on tigerlake machine.
> Bootstrapped and regtested on x86-64_iinux-gnu{-m32,}.
> Ok for GCC9?
>
> gcc/
> * common/config/i386/i386-common.c
> (processor_names): Add tigerlake.
> (processor_alias_table): Ditto.
> * config.gcc: Document -march=tigerlake.
Nope. Better.
(x86_64_archs): Ditto.
> * config/i386/driver-i386.c
> (host_detect_local_cpu): Detect tigerlake, add "has_avx" to
> classify processor.
> * config/i386/i386-c.c (ix86_target_macros_internal): Handle
> tigerlake.
Handle PROCESSOR_TIGERLAKE.
> * config/i386/i386.c (m_TIGERLAKE) : Define.
> (m_CORE_AVX512): Ditto.
You don't define this macro, but you add m_TIGERLAKE to m_CORE_AVX512.
Please correct this confusion.
> (processor_cost_table): Add tigerlake.
Please correct the above. You added skylake_cost.
> (ix86_option_override_internal): Handle PTA_MOVDIRI, PTA_MOVDIR64B.
Where?
> (processor_model): Add M_INTEL_COREI7_TIGERLAKE.
> (arch_names_table): Add tigerlake.
> (get_builtin_code_for_version) : Handle PROCESSOR_TIGERLAKE.
> * config/i386/i386.h (TARGET_TIGERLAKE): Define.
> (processor_type) : Add PROCESSOR_TIGERLAKE.
(enum processor_type)
> (PTA_TIGERLAKE) : Ditto.
Ditto what? This is a new define.
> * doc/extend.texi: Add tigerlake.
> * doc/invoke.texi: Add tigerlake.
Added where? To which section?
> gcc/testsuite/
> * gcc.target/i386/funcspec-56.inc: Handle new march.
> * g++.target/i386/mv16.C: Handle new march
Dot.
>
> libgcc/
> * config/i386/cpuinfo.h: Add INTEL_COREI7_TIGERLAKE.
(enum processor_subtypes)
>
> From-SVN: r274693
Please repost with improved/corrected ChangeLog.
Uros.
> --
> BR,
> Hongtao
