On Tue, Jan 31, 2012 at 8:36 PM, Ian Lance Taylor <i...@google.com> wrote:

>> There is no need for a panic in test/nilptr.go if array doesn't get
>> allocated in first 256 meg of memory. The compiler has nothing to do
>> with this.
>
> This is true but this does not seem like the right patch.

> I think I would prefer to just change go-test.exp to mark this test as
> xfail on Alpha.  A patch to do that is preapproved.

Attached is the patch I have committed.

2012-02-01  Uros Bizjak  <ubiz...@gmail.com>

        * go.test/go-test.exp (go-gc-tests): xfail test/nilptr.go runtime
        test on alpha*-*-*.

Tested on alphaev68-pc-linux-gnu, committed to mainline SVN.

(BTW: Do you have any idea on what to do with excessive memory usage
in chan/select2.go? )

Uros.
Index: go.test/go-test.exp
===================================================================
--- go.test/go-test.exp (revision 183805)
+++ go.test/go-test.exp (working copy)
@@ -305,6 +305,14 @@
            }
        }
 
+       # Handle certain tests in a target-dependant way.
+       if [istarget "alpha*-*-*"] {
+           if { [string match "*go.test/test/nilptr.go" $test] } {
+               go-execute-xfail $test
+               continue
+           }
+       }
+
        if { [string match "*bug347*" $test] \
                 || [string match "*bug348*" $test] } {
            # These bugs rely on runtime.Caller which currently fails.

Reply via email to