On Fri, Mar 26, 2021 at 04:19:56PM +0100, Tobias Burnus wrote:
> Hi Jakub,
>
> great suggestion – I did now as proposed.
>
> On 26.03.21 15:46, Jakub Jelinek via Gcc-patches wrote:
> > On Fri, Mar 26, 2021 at 03:42:22PM +0100, Tobias Burnus wrote:
> > > How about the following patch? It moves the aux function to
> > > libgomp.c-c++-common/on_device_arch.c
> > > and #includes it in the new wrapper files
> > > libgomp.{c,fortran}/on_device_arch.c.
> > > (Based on the observation that #include with relative paths always works,
> > > while dg-additional-sources may not, depending how the testsuite it run.)
> > > [...]
> > For C/C++, why do we call it on_device_arch.c at all? Can't be just
> > on_device_arch.h that is #included in each test instead of additional
> > sources? If we don't like inlining, just use noinline attribute, but I
> > don't see why inlining would hurt.
> > For Fortran, sure, we can't include it, so let's add
> > libgomp.fortran/on_device_arch.c that #includes that header.
>
> OK?
LGTM, but please give Thomas a chance to chime in.
Jakub
