On Thu, Mar 25, 2021 at 7:59 AM Uros Bizjak <ubiz...@gmail.com> wrote:
>
> On Wed, Mar 24, 2021 at 6:23 PM H.J. Lu <hjl.to...@gmail.com> wrote:
> >
> > For always_inline in system headers, we don't know if caller's ISAs are
> > compatible with callee's ISAs until much later.  Skip ISA check for
> > always_inline in system headers if caller has target attribute.
> >
> > gcc/
> >
> >         PR target/98209
> >         PR target/99744
> >         * config/i386/i386.c (ix86_can_inline_p): Don't check ISA for
> >         always_inline in system headers.
> >
> > gcc/testsuite/
> >
> >         PR target/98209
> >         PR target/99744
> >         * gcc.target/i386/pr98209.c: New test.
> >         * gcc.target/i386/pr99744-1.c: Likewise.
> >         * gcc.target/i386/pr99744-2.c: Likewise.
>
> LGTM.

It looks to me that this patch needs some more discussion, and the
solution isn't clear at all.

HJ, can you please revert the patch?

Thanks,
Uros.

Reply via email to