On Fri, Mar 12, 2021 at 09:04:33AM -0500, David Malcolm wrote: > > from the start of the function and add is_gimple_call (stmt) && > > in tree-ssa-strlen.c. > > Maybe even make it convert it to taking a "const gcall *", so those > > if (is_gimple_call (stmt)) > { > ... > if (gimple_call_alloc_size (stmt, ...)) > { > } > } > > become: > > if (const gcall *call = dyn_cast <const gcall *> (stmt)) > { > ... > if (gimple_call_alloc_size (call, ...)) > { > } > > }
I'm not a big fan of that, to me it means too much typing/clutter and think that runtime checking we have is sufficient, but could live with that. Jakub