I decided to use float_h_prefix instead of modename or mode prefix
as Joseph has better insight as to naming expectations when
others are working in gcc/c-family/c-cppbuiltin.c.
All requested changes made and tested. Patch coming shortly.
- patrick
On 2/19/2021 5:48 PM, Joseph Myers wrote:
On Fri, 19 Feb 2021, Patrick McGehearty via Gcc-patches wrote:
Here you're properly computing the mapping from mode to float.h macro
prefix (though I think "modename" is a confusing name for the variable
used for float.h macro prefixes; to me, "modename" suggests the names such
as SF or DF, which are actually "name" here, and something like
"float_h_prefix" would be better than "modename").
float_h_prefix puts me in mind of half-precision floating point rather than
float.h.
How would modeprefix do instead of modename?
I'm not sure modeprefix is better; you could say SF is the prefix of
SFmode, for example. Hence my suggestion of a name that makes clear it's
the prefix *in float.h*. typeprefix might be a possibility, as it's
really a prefix associated with a corresponding type rather than directly
with the mode.
