On Thu, Feb 04, 2021 at 01:31:52PM +0800, Hongtao Liu via Gcc-patches wrote: * gcc.target/i386/avx512vl-pr92686-vpcmp-1.c: This test is used to guard code generation of integer mask comparison, but for vector comparison to vector dest, integer mask comparison is disliked, so detele this useless test. * gcc.target/i386/avx512vl-pr92686-vpcmp-2.c: Ditto. * gcc.target/i386/avx512vl-pr92686-vpcmp-intelasm-1.c: Ditto.
s/detele/delete/; but I'd say just write : Remove. for all 3 tests, the explanation should go into the commit message, not ChangeLog. + /* When op_true is NULL, op_flase must be NULL, vice either. */ s/flase/false/ s/vice either/or vice versa/ + gcc_assert (!op_true == !op_false); + + /* When op_true/op_false is NULL or cmp_mode is not valid mask cmp mode, + vector dest is required. */ + if (!op_true || !ix86_valid_mask_cmp_mode (cmp_mode)) + return false; + + /* Exclude those could be optimized in ix86_expand_sse_movcc. */ s/those/those that/ Otherwise LGTM. Jakub