Richard Henderson <r...@redhat.com> writes: > On 01/28/2012 08:17 AM, Jakub Jelinek wrote: >> On Fri, Jan 27, 2012 at 01:04:41PM -0800, Ian Lance Taylor wrote: >>> This patch fixes the problem by introducing a new builtin function >>> __builtin_init_heap_trampoline. This is a middle-end change so it is >>> covered under my maintainership. I also believe it is quite safe. >>> However, given that we are in stage 4 I would like to ask the release >>> managers if this is OK to put in. It fixes a user-reported bug, but the >>> bug is technically not a regression because it has never actually worked >>> correctly. >>> >>> Bootstrapped and ran full testsuite on x86_64-unknown-linux-gnu. OK to >>> commit? >> >> Looks good to me, except I wonder whether the builtin needs to be user >> accessible. If not, can't you throw some * or space into the name, so that >> the builtin is really internal to gcc? > > Eh. The same could be said for the main __builtin_init_trampoline, > except that realistically this new one could actually be usable. > > Let's not start throwing around * unless it's likely to lead to an > ICE if misused.
I started testing the version with '*', but actually I agree with RTH. There are a number of __builtin functions which are basically unusable from user code. Let's handle them coherently. I will go ahead and submit as-is unless somebody objects shortly. Ian
