On Tue, Jan 19, 2021 at 12:24:51PM -0500, Michael Meissner wrote: > On Fri, Jan 15, 2021 at 03:43:13PM -0600, Segher Boessenkool wrote: > > Hi! > > > > On Thu, Jan 14, 2021 at 11:59:19AM -0500, Michael Meissner wrote: > > > >From 78435dee177447080434cdc08fc76b1029c7f576 Mon Sep 17 00:00:00 2001 > > > From: Michael Meissner <meiss...@linux.ibm.com> > > > Date: Wed, 13 Jan 2021 21:47:03 -0500 > > > Subject: [PATCH] PowerPC: Map IEEE 128-bit long double built-ins. > > > > > > This patch replaces patches previously submitted: > > > > What did you change after I approved it? > > You grumbled about the way I converted the names from the current name to the > IEEE 128-bit name as being unclear. > > 1) I moved the table of known mappings from within a function to a separate > function, and I populated the switch statement with all of the current names. > > 2) I moved the code that looks at a built-in function's arguments and returns > whether it uses long double to a separate function rather than being buried > within a larger function. > > 3) I changed the code for case we we didn't provide a name (i.e. new > built-ins) > to hopefully be clearer on the conversion.
Don't Do That. Commit what was approved (unless it actually does not work, then explain that clearly). You can sent incremental patches after that. I am not going to review this whole patch once again. If you change things in a series, the 0/N message is a good free-form place to explain that (and start sith a summary, and a summary of what is different from the previous version, for example). Some people keep a changelog of what changed in all version (newest on top of course). If there is only one patch, or you need to commemnt something on just one patch, you can do that after the "---" line. Everything before that line then is the exact commit message you will use (or anyone else can do it as well, with a simple "git am"). The goal of a patch submission is for it to be reviewed. Your submission should be optimised for that, not for anything else. So please send an incremental patch if you want more changes, or if the previous version was actually very much broken, explain what? Segher
