On Thu, Oct 08, 2020 at 09:27:56AM +1030, Alan Modra wrote: > Most cases use "return false" rather than breaking out of the switch. > Do so in all cases.
> default: > - break; > + return false; > } > - > - return false; > } Please don't do this part. The rest is okay. Thanks! Segher