One of the advantages of LRA is that you can create new pseudos from it just fine. The code in rs6000_emit_le_vsx_store was not aware of this. This patch changes that, in the process fixing PR98549 (where it is shown that we do call rs6000_emit_le_vsx_store during LRA, which we used to assert can not happen).
If this regstraps, I'll commit it tomorrow morning. Segher 2021-01-19 Segher Boessenkool <seg...@kernel.crashing.org> * config/rs6000/rs6000.c (rs6000_emit_le_vsx_store): Change assert. Adjust comment. Simplify code. --- gcc/config/rs6000/rs6000.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index 67681d1..108a527 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -9932,10 +9932,8 @@ rs6000_emit_le_vsx_load (rtx dest, rtx source, machine_mode mode) void rs6000_emit_le_vsx_store (rtx dest, rtx source, machine_mode mode) { - /* This should never be called during or after LRA, because it does - not re-permute the source register. It is intended only for use - during expand. */ - gcc_assert (!lra_in_progress && !reload_completed); + /* This should never be called after LRA. */ + gcc_assert (can_create_pseudo_p ()); /* Use V2DImode to do swaps of types with 128-bit scalar parts (TImode, V1TImode). */ @@ -9946,7 +9944,7 @@ rs6000_emit_le_vsx_store (rtx dest, rtx source, machine_mode mode) source = gen_lowpart (V2DImode, source); } - rtx tmp = can_create_pseudo_p () ? gen_reg_rtx_and_attrs (source) : source; + rtx tmp = gen_reg_rtx_and_attrs (source); rs6000_emit_le_vsx_permute (tmp, source, mode); rs6000_emit_le_vsx_permute (dest, tmp, mode); } -- 1.8.3.1