Hi Jakub, >> I have applied your other suggestions, and have retested the gomp.exp and >> libgomp tests. The full testrun started yesterday showed no regressions. If >> you have no further issues then I will commit this later tonight ahead of >> stage4. > > LGTM, thanks.
this patch broke Solaris bootstrap, but probably all non-Linux targets: /vol/gcc/src/hg/master/local/libgomp/task.c: In function 'task_fulfilled_p': /vol/gcc/src/hg/master/local/libgomp/task.c:334:1: error: control reaches end of non-void function [-Werror=return-type] 334 | } | ^ task_fulfilled_p is return __atomic_load_n (&task->completion_sem, __ATOMIC_RELAXED); but in config/posix/sem.h gomp_sem_t is (for !HAVE_BROKEN_POSIX_SEMAPHORES): typedef sem_t gomp_sem_t; and sem_t being a struct in Solaris <semaphores.h>. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University