Hi!
On Thu, Jan 14, 2021 at 03:25:46PM -0600, will schmidt wrote:
> This is a follow-up fix to clean up pr91799. Per review of test results,
> it appears that the combination of target and dg-require stanzas is
> not sufficient to properly limit the test to 64-bit only on darwin.
>
> This adds additional clauses to limit the test to 64-bit environments, and
> to configs that support at least power8 codegen.
> --- a/gcc/testsuite/gcc.target/powerpc/pr88233.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr88233.c
> @@ -1,6 +1,7 @@
> -/* { dg-do compile { target lp64 } } */
> +/* { dg-require-effective-target lp64 } */
This is needed on at least some versions of dejagnu :-(
This part is approved, as obvious even, if you need to change this in
any other test as well, that is pre-approved.
> +/* { dg-require-effective-target has_arch_pwr8 } */
> /* { dg-options "-O2 -mdejagnu-cpu=power8" } */
But this I do not see: it tests whether the host is power8, which isn't
right. You might want powerpc_p8vector_ok instead?
(There is nothing in the testcase that requires p8, certainly not on LE,
but it may be generating different code when targetting older machines,
so who knows -- that -mcpu=power8 was there already, and it does require
testing an effective target).
Okay for trunk with this fixed one way or another. Thanks!
Segher
