on 2020/12/31 下午6:01, Richard Biener wrote: > On December 31, 2020 8:02:37 AM GMT+01:00, "Kewen.Lin" <li...@linux.ibm.com> > wrote: >> Hi, >> >> As PR98464 shows, this patch is to make rpo_vn_valueize >> consider the definition basic block of name, to sync >> with what we do in function eliminate_stmt. >> >> Bootstrapped/regtested on powerpc64le-linux-gnu P9. >> >> Full SPEC2017 build/run passed on P9. > > Note it is incorrect to query availability at the context of a value, so the > patch isn't correct. I'll have a look after I return from vacation. >
Thanks Richard! I just passed the PR under your name. But I didn't quite follow your comments since the proposed change just extends vn_context_bb to the basic block which defines name, it looks it doesn't change querying availability or not. Not quite sure your comments are for the existing code or the change itself. Could you help to explain it a bit more? Thanks in advance. BR, Kewen
