On Thu, Dec 17, 2020 at 10:22 AM Nikhil Benesch <nikhil.bene...@gmail.com> wrote: > > On 12/17/20 1:05 PM, Ian Lance Taylor wrote: > > Thanks for looking into this. I've gotten confused now, though. > > Which patch fixes the problem on Solaris? Thanks. > > > > Ian > > The patch I submitted upstream is all that is needed to fix the > compilation failures on Solaris: > > https://go-review.googlesource.com/c/gofrontend/+/278672 > > That is the same patch as "solaris-godump.patch" in this thread. > > That patch does not fix the fishiness around dummy types that you > pointed out earlier. That is what the other patch was trying (but > failing) to address. But we don't need to fix that fishiness to fix > Solaris. The code in mk[r]sysinfo.sh that is getting confused by the > u?pad128_t dummy type turns out to be unnecessary. So the patch I sent > upstream just removes that code.
Thanks. Committed to mainline. Ian
