On Tue, 2012-01-24 at 19:12 -0500, Patrick Marlier wrote: > I propose some minor modifications to libitm.h: > * Add a link to current TM-ABI document.
We should link to libitm.texi instead because this describes the interface that we implement. > * Remove ITM_REGPARM from _ITM_beginTransaction since on x86-32, a > variadic function ignores regparm. > * Add ITM_PURE to _ITM_addUserCommitAction and _ITM_addUserUndoAction to > be usable inside transactions. Those should be called from transaction_pure code only, or from wrapper functions linked to using transaction_wrapper. Thus, they don't need to be pure. Alternatively, why should they be?