On 12/17/20 5:26 AM, Ian Lance Taylor via Gcc-patches wrote:
As discussed at
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561995.html ,
the ChangeLog checker does not correctly handle files with non-ASCII
file names.

This patch fixes the problem.  I have little experience with Python,
so I may have made some foolish mistakes here.

OK to commit?

Thanks.

Ian

* gcc-changelog/git_repository.py: Ignore quotation marks added by git
for non-ASCII file names.


First, sorry for a slow response about the previous
thread (Change to gcc/testsuite/go.test/test rejected by ChangeLog checker).

Well, the suggested change will not help us because we will not be able
to find a file with a given path (\xxx\yyy...).

Proper solution is likely doing:
$ git config --global core.quotepath false

both on server side (and client side).

Having that, git properly displays non-ascii filenames:

commit 1814a090a816884892240752c927f7dbb50a10da
Author: Martin Liska <mli...@suse.cz>
Date:   Fri Dec 18 11:00:52 2020 +0100

    Add new file.
ChangeLog: * špatně.txt: New file.

diff --git a/špatně.txt b/špatně.txt
new file mode 100644
index 00000000000..e69de29bb2d

Thoughts?
Martin

Reply via email to