Rainer Orth <r...@cebitec.uni-bielefeld.de> writes: > Hi Kyryll, > >>> Fixed by moving the memmove.h include in rtl-ssa.h before tm_p.h. >>> >>> Tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 (both into stage >>> 3 now, so the compilation error is gone). >>> >>> Ok for master? >> >> AFAIK simple patches like this that fix build/bootstrap are viewed as >> obvious and can be committed. >> I hope I'm not wrong 😊 > > I know, however I'm always unsure about the proper include order,
Me too TBH, as seen here. But I agree it looks like memmodel.h has to be included before tm_p.h. It looks like some files include emit-rtl.h without directly including tm_p.h (such as auto-inc-dec.c) so maybe that tm_p.h include was needed for something else. Or maybe auto-inc-dec.c gets it indirectly via something else. > thus asking for review. OK, thanks, and sorry for the breakage. Richard