+cc: Law, Biener, On Wed, 16 Dec 2020 at 20:27, Dimitar Dimitrov <dimi...@dinux.eu> wrote:
> On понеделник, 14 декември 2020 г. 20:53:36 EET Dimitar Dimitrov wrote: > > On петък, 11 декември 2020 г. 19:00:35 EET abebeos wrote: > > > After "digesting" a bit more your review, I need to thank you for > opening > > > my eyes re "cherrypick" suggestion and... the missing g++ summaries. I > > > need > > > to update my setup to provide the g++ test-deltas, too. Note that in my > > > test-setup, more c++ tests pass than in yours, not exactly sure why. > It's > > > in the "unresovled testcases". > > > > Regarding the additional "unresolved testcases" in my results. I traced > it > > to a bug in my setup. I did not prepare $HOME/.dejagnurc properly for > AVR. > > I'll rerun the tests and post the results. > > > > I'm using stock avr-libc, while I see you are using the avr-libc3 fork. > > Hopefully the main differences are in HW support, not core libc. > > > > Regards, > > Dimitar > > Here are the tests results with my environment fixes. Outcome is the same > - > saaadhu has no regressions. > Very nice! @all This review: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561757.html shows that there is still much work to do. But the patch author seems "away" (and not available anyways), the listed avr maintainer seems "super-away", main "executing analyst" (me) refuses to "touch even whitespace". To my understanding, the non-availability of the avr maintainer should mean that the "upper-up" maintainers decide. Commiting means essentially: => A low-quality avr-cc0 backend will be replaced with a 0-regressions low(possibly even lower)-quality avr-mode_cc backend. If anyone insists to polish things even more in context of a $7K bounty... start thinking about this: * Where is the line where bounty-work becomes IT-worker-abuse? * Do you want people start saying (rightfully) that "gcc bounties are essentially slave-labour"? * Enjoying fixed employment? And look at this: * 200h (estimation) for the patch * 200+h for the integration-work (dev-systems, testing etc.) - general reading not counted. * 100h (estimation) polishing * 400h (estimation) for quality enhancement no way, dishwashing pays better ( https://www.payscale.com/research/US/Job=Dishwasher/Hourly_Rate). I could, as a follow-up task, "enhance the quality of the avr-mode-cc backend", nothing special with the code. But me not sure if it's worth assimilating "gcc's md & related internals" to the point neccessary to fulfill the task at hand. I've done my work here. Note that I'll stop monitoring gcc-patches, but I'm still monitoring https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92729#c41 ================================================= > baseline beb9afcaf1466996a301c778596c5df209e7913c > === gcc Summary === > > # of expected passes 105527 > # of unexpected failures 584 > # of unexpected successes 16 > # of expected failures 582 > # of untested testcases 2 > # of unresolved testcases 33 > # of unsupported tests 5031 > > === g++ Summary === > > # of expected passes 146432 > # of unexpected failures 8012 > # of unexpected successes 21 > # of expected failures 624 > # of untested testcases 10 > # of unresolved testcases 3174 > # of unsupported tests 11112 > > > ================================================= > pipcet/avr-ccmode > === gcc Summary === > > # of expected passes 105431 > # of unexpected failures 709 > # of unexpected successes 16 > # of expected failures 582 > # of untested testcases 2 > # of unresolved testcases 69 > # of unsupported tests 5032 > > === g++ Summary === > > # of expected passes 146229 > # of unexpected failures 8291 > # of unexpected successes 21 > # of expected failures 624 > # of untested testcases 10 > # of unresolved testcases 3236 > # of unsupported tests 11112 > > ================================================= > saadhu/avr-cc0 > === gcc Summary === > > # of expected passes 105527 > # of unexpected failures 584 > # of unexpected successes 16 > # of expected failures 582 > # of untested testcases 2 > # of unresolved testcases 33 > # of unsupported tests 5031 > > === g++ Summary === > > # of expected passes 146432 > # of unexpected failures 8012 > # of unexpected successes 21 > # of expected failures 624 > # of untested testcases 10 > # of unresolved testcases 3174 > # of unsupported tests 11112 > > Regards, > Dimitar > > >
