> Or not :( We really shouldn't use SUBST there as it only deals with > rtx * It appeared better to invent a new SUBST for links given that > the type of this expression is struct insn_link rather than rtx * (Doh > !) I did think about hacking up a local flag but somehow like this > version better.
OK, I forgot that LOG_LINKS weren't RTX. > It's survived a bootstrap and testrun with no regressions for > c,c++,fortran,ada on one of the power7 machines for > powerpc64-unknown-linux-gnu in the compile farm. I'll put it through > it's paces for trunk (arm-linux-gnueabi / x86_64) and 4.6 (modulo API > changes for alloc_insn_link) if you think this looks better. Sure, that's clearly better. > 2012-01-23 Ramana Radhakrishnan <ramana.radhakrish...@linaro.org> > > PR rtl-optimization/48308 > * combine.c (do_SUBST_LINK): Declare and define. > (SUBST_LINK): New. > (try_combine): Handle LOG_LINKS for dummy i1 case. You also need to document the changes made to enum undo_kind, struct undo, do_SUBST and undo_all. OK with these changes. -- Eric Botcazou
