On 11/26/20 12:24 PM, Ilya Leoshkevich via Gcc-patches wrote:
> Bootstrapped and regtested on x86_64-redhat-linux and
> s390x-redhat-linux.  Ok for master?
>
>
>
> During ICE reporting, sometimes rtl_dump_bb is called on partially
> initialized basic blocks.  This produces another ICE, obscuring the
> original problem.
>
> Fix by checking that that basic blocks are initialized before touching
> their bb_infos.
>
> gcc/ChangeLog:
>
> 2020-11-25  Ilya Leoshkevich  <i...@linux.ibm.com>
>
>       * cfgrtl.c (rtl_bb_info_initialized_p): New function.
>       (rtl_dump_bb): Use rtl_bb_info_initialized_p before accessing bb
>       insns.
I think reality is that these routines are never going to be 100% safe
in terms of not ICEing themselves (after all, the ICE might be an
internal inconsistency in the RTL IL itself), this seems like a
reasonable amount of sanity checking.

OK.

jeff

Reply via email to