On 11/20/20 7:42 PM, Matthew Malcomson wrote:
On 13/11/2020 17:22, Martin Liška wrote:
On 11/13/20 5:57 PM, Matthew Malcomson wrote:
Hi there,
Thanks for the heads-up.
As it turns out the most recent `libhwasan` crashes when displaying an address
on the stack in Linux.
Hello.
What a bad luck.
I'm currently working on getting it fixed here
https://reviews.llvm.org/D91344#2393371
<https://reviews.llvm.org/D91344#2393371> .
If this hwasan patch series gets approved and if that patch goes in would it be
feasible to bump the libsanitizer merge to whatever version that would be?
If not (maybe because stage1 would be finished?) then could/would we end up
using the LOCAL_PATCHES approach?
Since now, I would prefer doing cherry picks. Hopefully, we'll end just with
couple of patches.
That makes sense, there's just one patch I need 83ac1820.
As far as I can tell from the history, the process is simply to apply the patch
in GCC, commit it with a ChangeLog etc as if it were a GCC patch, and then add
the hash into LOCAL_PATCHES as a separate commit.
Hello.
Just add it as we did for e.g. b69f33f477b9ac38af3c39465600ae74a3554878.
You don't need to write ChangeLog entries. Note that libsanitizer is one of the
location
where we are not strict about ChangeLog format verification.
And yes, then you add it simply to LOCAL_PATCHES.
Is that right?
Given that it looks like the hwasan patch series is nearing going in now, I'd
like to make sure I know how the library is getting added.
Is the plan something like the below?
1) You add the libhwasan update (i.e. this patch you posted).
2) I add the cherry-pick from LLVM compiler-rt (once it's approved)
and a separate commit updating LOCAL_PATCHES.
3) I add the hwasan patch series.
Yes.
Or would it make more sense for me to apply your patch below with `--author`
using your details (so it goes in the ChangeLog that way)?
Don't worry with that, just apply it as you want.
Thanks,
Martin
Thanks!
Matthew
Thanks,
Martin
Thanks,
Matthew
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
*From:* Martin Liška <mli...@suse.cz>
*Sent:* 13 November 2020 16:33
*To:* Matthew Malcomson <matthew.malcom...@arm.com>; gcc-patches@gcc.gnu.org
<gcc-patches@gcc.gnu.org>
*Cc:* ja...@redhat.com <ja...@redhat.com>; Richard Earnshaw <richard.earns...@arm.com>;
k...@google.com <k...@google.com>; do...@redhat.com <do...@redhat.com>; jos...@codesourcery.com
<jos...@codesourcery.com>
*Subject:* Re: [Patch 0/X] HWASAN v4
On 10/16/20 11:03 AM, Martin Li�ka wrote:
Hello.
I've just merged libsanitizer and there's the corresponding part that includes
libhwasan.
Martin
Hey.
I've just made last merge from upstream, there's corresponding hwasan part.
Martin
