Hi everyone, Apologies again for the delay on my end, the past few weeks have been hectic and exhausting.
The changes look good and pass the testing I was doing for my version of the patch. Feel free to commit Nikhil's latest patch for us. Thanks, - Eddy B. On Fri, Nov 13, 2020, at 08:42, Nikhil Benesch wrote: > On 11/6/20 12:09 PM, Jeff Law wrote: > > So I think the best path forward is to let you and Eduard-Mihai make the > > technical decisions about what bits are ready for the trunk. When y'all > > think something is ready, let's go ahead and get it installed and > > iterate on things that aren't quite ready yet. > > > > > > For bits y'all think are ready, ISTM that Eduard-Mihai should commit the > > changes. > > I've attached an updated version of the patch that contains some > additional unit tests that eddyb noticed I lost. From my perspective, > this is now ready for commit. > > Neither eddyb nor I have write access, so someone else will need to > commit. (But please wait for eddyb to sign off too.) > > > It's better to get it in sooner, but there is some degree of freedom > > depending on the impact of the changes. Changes in the rust demangler > > aren't likely to trigger codegen or ABI breakages in the compiler itself > > -- so with that in mind I think we should give this code a higher degree > > of freedom to land after the stage1 close deadline. > > Got it. Thanks. That's very helpful context. > > Nikhil > > Attachments: > * rust-demangle.patch
