Hi Thomas, Yes, it did grow into a bit of a monster patch. I kept noticing rather flakey bits of existing code, especially where matching of dtype element lengths to the actual payload was concerned.
Waiting for the others to comment gives me a chance to write a more comprehensive testcase for the handling of temporaries. Note also that PR96012 is fixed by this patch and will require an additional test. I am happy to leave dependency_57.f90 as it is and add an additional test. I will post the tests as soon as they are available. Thanks for taking a look at it. Paul Paul On Tue, 10 Nov 2020 at 22:16, Thomas Koenig <tkoe...@netcologne.de> wrote: > Hi Paul, > > > This all bootstraps and regtests on FC31/x86_64 - OK for master? > > This is a sizable patch, and from what I can see, it all looks > plausible. So, I's say OK for master (with one nit, below), > but maybe you could wait a day or so to give others the chance > to look it over, too. > > The nit: > > > PR fortran/83118 > > * gfortran.dg/dependency_57.f90: Change to dg-run and test for correct > > result. > > I'd rather not change a test case unless it is needed; if something > breaks it, it is better to leave it as is for bisection. > > Could you just make a new test from the run-time version? > > Thanks a lot for tackling this thorny issue! > > Best regards > > Thomas > > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein
