On 11/6/20 4:51 PM, Segher Boessenkool wrote: > The ABI break is all GCC's faultt, but it is exposed by that glibc code, > sure :-)
Right, and I'm thankful it was caught (fairly) early enough! >> This passes bootstrap and regtesting on powerpc64le-linux with no >> regressions. >> Ok for mainline and the GCC 10 release branch after some burn in? > > Yes, okay for both. Thanks! Thanks, pushed to trunk. I'll push to GCC 10 in a day or two. >> + Since the test below doesn't need any other MMA support, we can enable >> + this test case on basically any cpu that has hard floating point >> + registers. */ > > Good comment, thanks :-) That "basically" does not sound super > convincing, but this is just a testcase, we can fix it later if need be. The types and built-ins are enabled with TARGET_EXTRA_BUILTINS which is a conglomeration of a lot of different target flags. The hard float test seemed like the test that would allow it to be run on the most targets, but being disabled when it should be. Yeah, we can fix it if we trip over it somehow. Peter
