On Thu, Oct 29, 2020 at 01:03:25PM -0400, Michael Meissner wrote:
> On Tue, Oct 27, 2020 at 06:27:22PM -0500, Segher Boessenkool wrote:
> > > +/* { dg-do compile { target { powerpc*-*-linux* } } } */
> >
> > Use *-*-linux* instead? (In all relevant tests.)
>
> Ok.
>
> > Is there any reason these tests should only run on Linux? If not, it
> > should not restrict itself like this; and if so, you may want another
> > selsector (something ieee128 perhaps), or at the very least add a
> > comment why you do this.
>
> Right now the float128 emulation is only built on Linux, because it needs the
> support in GLIBC. If/when other systems add support for float128 in there
> C/C++ libraries, we can widen the tests.
It still helps to use some new selector -- you only have to change the
implementation of that when such a day will come, instead of 34638
separate testcases. Also, it is good documentation, helping every
reader (people trying to make sense if the tests, for example).
Segher
