Correct MIPS I assembly build errors in switchcontext.S:
.../libphobos/libdruntime/config/mips/switchcontext.S: Assembler messages:
.../libphobos/libdruntime/config/mips/switchcontext.S:50: Error: opcode not
supported on this processor: mips1 (mips1) `sdc1
$f20,(0*8-((6*8+4+(-6*8+4&7))))($sp)'
etc., due to the use of the MIPS II LDC1 and SDC1 hardware instructions
for FP register load and store operations. Instead use the L.D and S.D
generic assembly instructions, which are strict aliases for the LDC1 and
SDC1 instructions respectively and produce identical machine code where
the assembly for the MIPS II or a higher ISA has been requested, however
they become assembly macros and expand to compatible sequences of LWC1
and SWC1 hardware instructions where the assembly for the MIPS I ISA is
in effect.
libphobos/
* libdruntime/config/mips/switchcontext.S [__mips_hard_float]:
Use L.D and S.D generic assembly instructions rather than LDC1
and SDC1 MIPS II hardware instructions.
---
Hi,
Noticed in a build of a MIPS I toolchain. I have no way to run MIPS
regression-testing right now, however in `libopcodes' the L.D and S.D
instructions are strict aliases valid for the MIPS II and higher ISAs, and
just to double-check that I have built MIPS32r2 GCC with and without the
change applied and verified with `objdump' that the respective target
objects produced are identical.
OK to apply to trunk, and -- as a fatal compilation error -- to backport
to active release branches?
Maciej
---
libphobos/libdruntime/config/mips/switchcontext.S | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
gcc-libphobos-mips1.diff
Index: gcc/libphobos/libdruntime/config/mips/switchcontext.S
===================================================================
--- gcc.orig/libphobos/libdruntime/config/mips/switchcontext.S
+++ gcc/libphobos/libdruntime/config/mips/switchcontext.S
@@ -47,12 +47,12 @@ see the files COPYING3 and COPYING.RUNTI
#ifdef __mips_hard_float
#define ALIGN8(val) (val + (-val & 7))
#define BELOW (ALIGN8(6 * 8 + 4))
- sdc1 $f20, (0 * 8 - BELOW)($sp)
- sdc1 $f22, (1 * 8 - BELOW)($sp)
- sdc1 $f24, (2 * 8 - BELOW)($sp)
- sdc1 $f26, (3 * 8 - BELOW)($sp)
- sdc1 $f28, (4 * 8 - BELOW)($sp)
- sdc1 $f30, (5 * 8 - BELOW)($sp)
+ s.d $f20, (0 * 8 - BELOW)($sp)
+ s.d $f22, (1 * 8 - BELOW)($sp)
+ s.d $f24, (2 * 8 - BELOW)($sp)
+ s.d $f26, (3 * 8 - BELOW)($sp)
+ s.d $f28, (4 * 8 - BELOW)($sp)
+ s.d $f30, (5 * 8 - BELOW)($sp)
#endif
sw $ra, -4($sp)
@@ -72,12 +72,12 @@ see the files COPYING3 and COPYING.RUNTI
move $sp, $a1
#ifdef __mips_hard_float
- ldc1 $f20, (0 * 8 - BELOW)($sp)
- ldc1 $f22, (1 * 8 - BELOW)($sp)
- ldc1 $f24, (2 * 8 - BELOW)($sp)
- ldc1 $f26, (3 * 8 - BELOW)($sp)
- ldc1 $f28, (4 * 8 - BELOW)($sp)
- ldc1 $f30, (5 * 8 - BELOW)($sp)
+ l.d $f20, (0 * 8 - BELOW)($sp)
+ l.d $f22, (1 * 8 - BELOW)($sp)
+ l.d $f24, (2 * 8 - BELOW)($sp)
+ l.d $f26, (3 * 8 - BELOW)($sp)
+ l.d $f28, (4 * 8 - BELOW)($sp)
+ l.d $f30, (5 * 8 - BELOW)($sp)
#endif
lw $ra, -4($sp)
