Hi, On Wed, Sep 30 2020, Richard Biener wrote: > On Tue, Sep 29, 2020 at 9:31 PM Jan Hubicka <hubi...@ucw.cz> wrote: >> >> > >> > gcc/ChangeLog: >> > >> > 2020-09-07 Martin Jambor <mjam...@suse.cz> >> > >> > * params.opt (ipa-cp-large-unit-insns): New parameter. >> > * ipa-cp.c (get_max_overall_size): Use the new parameter. >> OK, > > Maybe the IPA CP large-unit should be a factor of the large-unit > param? Thus, make the new param ipa-cp-large-unit-factor > instead so when people increase large-unit they also get "other" > large units increased accordingly?
I do not have a very strong opinion about this but I think that having two separate parameters will make it easier for us to experiment with the passes and is probably easier to document and thus also easier for users who want to play with this to understand. On the other hand, having a single param to tune sensitivity of all IPA towards sizes - or just what big size means - does not seem like such a big advantage to me. But I guess I could be persuaded otherwise. Thanks, Martin
