> I think it should be unconditionally restrict splitting (I suppose on the
> trunk the __builtin_constant_p is optimized away already).
> 
> Btw, this will also disqualify any point below
> 
>  if (__builtin_constant_p (...))
>    {
>      ...
>    }
> 
> because after the if join all BBs are dominated by the __builtin_constant_p
> call.  What we want to disallow is splitting at a block that is dominated
> by the true edge of the condition fed by the __builtin_constant_p result ....
> 
> Honza?
Well, just for record, the final version of patch seems to make sense for me ;)
Thanks! It is an interesting side corner to say at least.

Honza

Reply via email to