On Sun, 2020-09-20 at 19:30 +0200, Jan Hubicka wrote: > > On Sun, 2020-09-20 at 00:32 +0200, Jan Hubicka wrote: > > > Hi, > > > this is cleaned up version of the patch. I removed unfinished > > > bits, > > > fixed > > > propagation, cleaned it up and fixed fallout. > > > > [...] > > > > > While there are several areas for improvements but I think it is > > > not > > > in shape > > > for mainline and rest can be dealt with incrementally. > > > > FWIW I think you typoed: > > "not in shape for mainline" > > when you meant: > > "now in shape for mainline" > > given... > > Yep, sorry for that :)
I've started seeing crashes in the jit testsuite even with trivial inputs, which are happening at pass_modref::~pass_modref at: 772 ggc_delete (summaries); on the first in-process iteration of the code, with: (gdb) p summaries $3 = (fast_function_summary<modref_summary*, va_gc> *) 0x0 I'm still investigating (but may have to call halt for the night), but this could be an underlying issue with the new passes; the jit testsuite runs with the equivalent of: --param=ggc-min-expand=0 --param=ggc-min-heapsize=0 throughout to shake out GC issues (to do a full collection at each GC opportunity). Was this code tested with the jit? Do you see issues in cc1 if you set those params? Anyone else seeing "random" crashes? Thanks Dave
