The SRA pass relies on the absence of function type attributes
to enable optimization like unused argument elision. The intent
appears to be to avoid messing with the positions of arguments
that may be relied on by some type attributes.
The recent enhancement to detect out-of-bounds accesses by array
(including VLA) function arguments relies on the C front end
implicitly adding attribute access to the types if functions that
take such arguments. This in turn interferes with a few SRA tests
that make use of the array notation in the declaration of the argv
array in main().
Since the use of the array notation is incidental to the purpose
of the SRA tests, to clean up the failures in r11-3333 I have
committed the attached patch to avoid incidental failures due
to implicit attribute access.
In case it's important to preserve the SRA optimization in the case
of array arguments that don't depend on their positions in the argument
list (only a subset of VLAs do so it seems like it would be nice to
keep it for the rest) I'm testing a followup enhancement to let SRA
recognize the new access attribute and let the optimization take
effect even its presence. I'll post this patch once I'm done
testing it.
Martin
commit 05193687dde2e5a6337164182a1946b584acfada
Author: Martin Sebor <mse...@redhat.com>
Date: Mon Sep 21 14:33:29 2020 -0600
Avoid incidental failures due to implicit attribute access.
gcc/testsuite/ChangeLog:
PR c/50584
* gcc.dg/ipa/ipa-sra-1.c: Use a plain pointer for argv instead of array.
* gcc.dg/ipa/ipa-sra-12.c: Same.
* gcc.dg/ipa/ipa-sra-13.c: Same.
* gcc.dg/ipa/ipa-sra-14.c: Same.
* gcc.dg/ipa/ipa-sra-15.c: Same.
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-sra-1.c b/gcc/testsuite/gcc.dg/ipa/ipa-sra-1.c
index 4a22e3978f9..df7e356daf3 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-sra-1.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-sra-1.c
@@ -24,7 +24,7 @@ ox (struct bovid cow)
}
int
-main (int argc, char *argv[])
+main (int argc, char **argv)
{
struct bovid cow;
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-sra-12.c b/gcc/testsuite/gcc.dg/ipa/ipa-sra-12.c
index 4d9057e6353..0cc76bde319 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-sra-12.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-sra-12.c
@@ -34,7 +34,7 @@ bar (struct S s)
}
int
-main (int argc, char *argv[])
+main (int argc, char **argv)
{
struct S s;
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-sra-13.c b/gcc/testsuite/gcc.dg/ipa/ipa-sra-13.c
index 4d4ed74cfd6..e8751dad67f 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-sra-13.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-sra-13.c
@@ -33,7 +33,7 @@ bar (struct S *s)
}
int
-main (int argc, char *argv[])
+main (int argc, char **argv)
{
struct S s;
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-sra-14.c b/gcc/testsuite/gcc.dg/ipa/ipa-sra-14.c
index 3ca302c77e2..75619c67b09 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-sra-14.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-sra-14.c
@@ -43,7 +43,7 @@ bar (struct S s)
}
int
-main (int argc, char *argv[])
+main (int argc, char **argv)
{
struct S s;
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-sra-15.c b/gcc/testsuite/gcc.dg/ipa/ipa-sra-15.c
index 6c57c7bcebc..aa13a94c7c0 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-sra-15.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-sra-15.c
@@ -45,7 +45,7 @@ bar (struct S *s, int rec)
volatile int g;
int
-main (int argc, char *argv[])
+main (int argc, char **argv)
{
struct S s;
